Media asset pages should stop merging claimed sources with real sources

I think it is intended to be a feature that claimed sources should look the exact same as real sources on the media asset page. There is visible work in it: when someone goes to the media asset page, the server goes to the post page, gets the post source field, checks if it matches one of the real sources, and
if not, it decorates the claimed source with favicon and everything, and puts it among the sources (thankfully, to the very end).

In practice it is an anti-feature, and it makes it hard/unintuitive to check if an image is really pulled from its claimed source, or not. For websites like twitter at least.

They should look different. E.g. claimed sources could get a different colored row in the source list

reg_panda said:

when someone goes to the media asset page, the server goes to the post page

Wrong. Those links are populated by the upload page when an upload is converted into a media asset. They can't be manually edited.

That's not true, the source field on the media asset page *can* be manually edited. And it is *done*, many many times.

Here's a picture from twitter:
post #7938618
https://danbooru.donmai.us/media_assets/22532209

And here is a picture with a fake twitter source:
post #7927513
https://danbooru.donmai.us/media_assets/22503966
(I've hijacked an off topic image.)

You can see both the source field on the right side, and both the twitter logo look exactly the same for the media asset pages.

Danbooru is full of fake sources, and despite the server having the information if a source is true, the UI works really really hard to hide this information.
People have no way to tell if a source was real (but became dead, or changed), or it was never real in the first place. Which information Danbooru has, but decides to hide it.

reg_panda said:

That's not true, the source field on the media asset page *can* be manually edited. And it is *done*, many many times.

How? I couldn't find any option to do so. However, I did notice that your fake source disappeared from the media asset when I removed it from the uploaded post. That's an automatic process, not a manual one.

Anyway, please don't add fake sources to posts to prove a point, even if the post is off-topic.

Ah, I see what you mean. I think we misunderstood each other.

To be clear, the media asset does not actually have a source field. The sources are not a property of the media file, but of another object, and they're represented on the fly every time a media asset page is fetched. If you look at the database structure you'll see media assets actually have no information on the source. When you change a post's source, you're not doing anything to the media file. Instead, the media page is pulling that info from two different objects: the post, and the upload media asset (which is different from the media asset).

People have no way to tell if a source was real (but became dead, or changed), or it was never real in the first place. Which information Danbooru has, but decides to hide it.

There's a number of issues that would come with not displaying sources from posts in the media asset page: all the unsupported sites, for one, would never display their source in the media assets, because users uploaded them manually.
There's also a major backward compatibility issue: the media asset vs upload vs post logic is a relatively recent change (3 years ago), so all posts created before this system don't actually have that info, as uploads used to be regularly pruned after 2 months IIRC. The original data is gone forever.
Take any random post from pixiv:any age:>4y and you'll see that they have the same issue you found in post #7927513. This would mean about half the posts in our database would not be able to display their original source in the media asset, which would go against the purpose of having those links there in the first place.

There's a number of issues that would come with not displaying sources from posts in the media asset page: all the unsupported sites, for one, would never display their source in the media assets, because users uploaded them manually.

I proposed "They should look different. E.g. claimed sources could get a different colored row in the source list". Or: separate them with a visible space. Slap a css class on it, then a css rule, it probably wouldn't even break anything that builds on danbooru (bots, scripts, and such).

There's also a major backward compatibility issue: the media asset vs upload vs post logic is a relatively recent change (3 years ago), so all posts created before this system don't actually have that info, as uploads used to be regularly pruned after 2 months IIRC. The original data is gone forever.

Take any random post from pixiv:any age:>4y and you'll see that they have the same issue you found in post #7927513. This would mean about half the posts in our database would not be able to display their original source in the media asset, which would go against the purpose of having those links there in the first place.

I wasn't aware that upload info is only 3 years old. Still, it would be a help for the posts after that.